data file download race condition

[bridiver]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
If a new data file is available (either first run or file updated), https everywhere, tracking protection and ad blocking will be disabled until they are loaded, but they appear as "on" in the bravery panel. There are a few ways we can handle this:

1. Leave as-is, but notify the user that shields are down until the file is downloaded
2. Delay the loading of any pages until the files are downloaded and notify the user of the download progress

When updates are available we should also start immediately with the old files and swap when the new ones are available.

[bridiver]

if we want to be completely sure they are loaded, we could also apply this to locally read files

[diracdeltas]

I'm in favor of 1 since 2 will always make us look slow whenever there's an update

[bbondy]

Strong preferences for 1 over 2.

[bridiver]

actually there is a 3rd option which is to download the files on install

[bridiver]

cc @bradleyrichter

[BrendanEich]

Download on install == win/win, is it hard?

[diracdeltas]

Even if they are downloaded on install, we need to check for updates every ~24 hours so I don't think that solves the problem

[diracdeltas]

NVM, I forgot that the old file will be active while the update is being downloaded, so that does seem like a win win

[bbondy]

Download on install is not possible when you have no running code on install. Only Windows has this.

[bridiver]

There are hooks available on Mac when you copy to and delete from /Applications and on Linux a deb or similar can run code

On Jul 12, 2016, at 3:36 PM, Brian R. Bondy notifications@github.com wrote:

download on install is not possible when you have no running code on install. Only Windows has this.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

[bbondy]

This is very platform dependent though and moves the implementation to something that locks us into the way we are distributing. Longer term I think we'll end up in the mac store for example. Also we could change installers completely to be only msi based one day. Windows store is another place we'll end up in the future.

[bradleyrichter]

#1 is my pref.

We can show the shields button as disabled and display a "please wait while shields are being updated. "