Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Title and location of blocked page are renamed in bookmark dialog #2601

Closed
luixxiul opened this issue Jul 20, 2016 · 4 comments
Closed

Title and location of blocked page are renamed in bookmark dialog #2601

luixxiul opened this issue Jul 20, 2016 · 4 comments

Comments

@luixxiul
Copy link
Contributor

I'm not sure if it works as it should or not.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.11.0
  • Steps to reproduce:
    1. Make sure the bravery shield is on
    2. Go to http://excellentmovies.net
    3. CTRL+D
  • Screenshot if needed:
    clipboard01
  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Jul 20, 2016

seems like a special case should be made when the URL is about:error or about:certerror or about:safebrowsing to use the provisionalLocation URL only and a blank title.

@pranoy10
Copy link

May I work on this issue?

@srirambv
Copy link
Collaborator

The current bookmark dialogue is changed. This is what you get when you add bookmark via keyboard shortcut
image

However edit bookmark brings up the following
image

Not sure if this is still a valid bug. @bsclifton could you confirm?

@NejcZdovc NejcZdovc added the help wanted The PR/issue opener needs help to complete/report the task. label May 7, 2018
@bsclifton
Copy link
Member

Definitely not an issue anymore (just verified- same results as @srirambv above). Closing

@bsclifton bsclifton removed this from the Triage Backlog milestone Jun 18, 2018
@bsclifton bsclifton removed bug/good-first-bug help wanted The PR/issue opener needs help to complete/report the task. labels Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants