Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Dark UI #271

Closed
ghost opened this issue Jan 23, 2016 · 162 comments
Closed

Add Dark UI #271

ghost opened this issue Jan 23, 2016 · 162 comments
Labels
accessibility fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. initiative/ux-harmonization product/user-happiness suggestion usability

Comments

@ghost
Copy link

ghost commented Jan 23, 2016

As there are people around which are unable to look at a light UI only because of their eyes. I am such a person, but there are tons of others around with such an issue.

Hopefully you take this into account for future releases. Thanks!


edit by @luixxiul

If you have a serious eye problem, definitely f.lux is worth trying.
You can grab a copy here: https://justgetflux.com/

also see below: #271 (comment)

Until every variable which defines color of the UI will be moved to theme.js, it will never be available.

@ghost ghost changed the title Please add also a dark UI at some point Please add also a dark UI at some point - for people which get eye problems with light UI elements Jan 23, 2016
@ghost ghost changed the title Please add also a dark UI at some point - for people which get eye problems with light UI elements Please add also a dark UI at some point - for people which experience eye issues with light UI elements Jan 23, 2016
@Krutonium
Copy link
Contributor

👍

@bnvk
Copy link

bnvk commented Jan 25, 2016

This would be great to have 👍 indeed!

@Adejair
Copy link
Contributor

Adejair commented Jan 25, 2016

👍

@bbondy
Copy link
Member

bbondy commented Jan 25, 2016

might be a little early to have it while we're building out the UI elements, but definitely would like to have this later. Ideally an easy way to install the themes in.

@luixxiul luixxiul changed the title Please add also a dark UI at some point - for people which experience eye issues with light UI elements Add Dark UI May 21, 2016
@luixxiul luixxiul mentioned this issue May 21, 2016
@Arandhras
Copy link

I like this, too! Please implement it!

@bradleyrichter
Copy link
Contributor

coming to a future near you:

image

Can't wait to design it. I'm currently using PSD in dark and AI in light because the toolbars are otherwise confusing!

@ghost
Copy link
Author

ghost commented May 23, 2016

Hopefully this includes future elements too like history background, download/bookmark page background.

@wastedsunsets
Copy link

Dark theme would have this browser as my daily driver.

@idprism
Copy link

idprism commented Jul 22, 2016

upvote. more likely to use applications that dont hurt my eyes on open.

@srirambv
Copy link
Collaborator

srirambv commented Dec 5, 2016

+1 from support

@yannduran
Copy link

👍

@luixxiul luixxiul added this to the Backlog milestone Jan 8, 2017
@ace72
Copy link

ace72 commented Feb 14, 2017

+1 dark theme as of now cant use this browser at night hurts my eye i hope this gets implemented real soon!

@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Mar 8, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 9, 2017
@pietercdevries
Copy link

Is this issue resolved yet? I love the browser but I'am forced to use chrome since I can install dark theme on browser and Gmail. I have a sensitivity to light and already have my displays brightness down. Thanks

@cndouglas
Copy link

@pietercdevries: Not yet, but it will be implemented before or with the release of Brave 1.0.

@pietercdevries
Copy link

Thank you very much!

@ninthbelief
Copy link

Just commenting to say that I'm interested as well. The lack of a dark theme is the number one reason I haven't switched to Brave yet.

@AnthoniG
Copy link

image

Just to say that I too really want this.
I have a serious eye problem and can not use Brave as it's too light for me and seriously hurts my eyes.
Adding a Dark theme / UI options would be brilliant.

@ghost
Copy link
Author

ghost commented Jul 5, 2018

+1000

@greyl0ck
Copy link

greyl0ck commented Jul 6, 2018

+1 👍

@lunarthegrey
Copy link

+1 👍

@JonnyRedHed
Copy link

JonnyRedHed commented Jul 11, 2018

For me its more than just the UI that needs to be dark. Having support for Stylus is also important. I make every dark when I can, not black dark but dark deep blue/grey etc, dimmed white text etc. And when not using stylus and I come across a white BG news article etc, I use the chrome extension 'Care your eyes'.

So can we have support for at least Stylus please. Your own Dark UI will be great, just like when Opera added there dark mode UI. Also the back end settings pages, extension page etc would be good to also have dark.

I'm no coder so cannot help out in this respect, and it has been explained to me its tricky to do for Opera and Brave adding a dark mode Ui for the background settings pages and drop down menus and on page right click mouse context menu. But having it on the drop downs and right click context menus would be really cool, once dark mode is turned on. Maybe have settings section so one can fine tune what parts of the UI are dark, as some might still prefer light default right click context and drop down menus.


An old post below here showing Stylus and Care your Eyes links. And how to make pages dark with care your eyes.

For me at the moment to make web pages dark, the best two options are below in my opinion.

'Care your eyes' - chrome extension - can be used in Opera, Chrome, Vivaldi etc. Good for random web pages you want dark. Such as some white background article you land on etc but may never return to that site.

Care your eyes uses a nice dark brown hue for the dark mode which is quite a nice balance of night time or dimmed room colors. It also Remembers top level domains. Dev is working on remembering single pages rather than just top level domain.

*set up: choose white list mode, then just use the 'Enable at this site' to make a page dark and have it remember. Very easy for those random web pages and articles you want dark.

url:
https://chrome.google.com/webstore/detail/care-your-eyes/fidmpnedniahpnkeomejhnepmbdamlhl

--
Stylus - better than Stylish - no data mining etc of your history and habits.
Far fewer permissions than stylish.
https://chrome.google.com/webstore/detail/stylus/clngdbkpkpeebahjckkjfobafhncgmne?hl=en

Stylus Dark UI - Manage styles page etc with the stylus UI in dark mode.
https://userstyles.org/styles/142097/stylus-gray-matter-chromium-based-or-firefox

@tconn89
Copy link

tconn89 commented Jul 19, 2018

👍
+1 for Dark mode!

@JonnyRedHed
Copy link

Supporting the extension Stylus would be a big step for allowing users to darken the webpages they visit. And then in time (and its been some time already) your add a dark UI including all the back end settings and extensions pages :)

@so-lost
Copy link

so-lost commented Jul 21, 2018

+1 👍

@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@kekukui
Copy link

kekukui commented Aug 5, 2018

When you say "Dark UI" there are really two separate issues here: a dark theme for the browser, and a night reader mode for web sites. While TLV and Dark Reader both have 5-star ratings in the Chrome store, Dark Reader has a much larger user base. I have not tested TLV, but did try everything else I could find in the way of night browsing extensions. The result of those tests is that Dark Reader seems to make the fewest mistakes when inverting bright pages and graphics. After browsing thousands of sites over several months, I only found a couple dozen which Dark Reader did not handle adequately... and development is constantly progressing. I would have tested TLV too, if it worked on Firefox like Dark Reader does. So I would suggest that TLV or Dark Reader should be incorporated as default options in Brave. Unfortunately, I cannot use Brave on a regular basis without a night reading mode.

TLV
https://chrome.google.com/webstore/detail/tlv-night-mode/jdkclpamgobjdopkemcojdhbfddoplgg

Dark Reader
https://chrome.google.com/webstore/detail/dark-reader/eimadpbcbfnmbkopoojfekhnkhdbieeh

@JonnyRedHed
Copy link

JonnyRedHed commented Aug 5, 2018

A dark UI, like Opera (stable), and in time extending the dark UI onto the back end pages like Opera developer browser is doing now for 'settings' and 'update' and 'experiment' pages. They have yet to make the extensions page part of the dark mode UI.

I hope brave follows this example.

And then, for me they just need to allow the Stylus extension, then we can import our own set of dark styles or hunt for them on userstyles.org. And for those pages I just happen upon that I want to darken just to read an article or what ever, then I use the 'Care your Eyes' Extension. Its night time mode is a nice dark brown hue/blend.

@kekukui
Copy link

kekukui commented Aug 6, 2018

@JonnyRedHed

they just need to allow the Stylus extension, then we can import our own set of dark styles

You can make your own styles with Dark Reader, try it =)

@JonnyRedHed
Copy link

Brave supports neither at the moment.

@kekukui
Copy link

kekukui commented Aug 16, 2018

Half of the population will never use Brave if it does not support extensions, and the company will go out of business

@eljuno
Copy link
Contributor

eljuno commented Aug 16, 2018

@h3298 please see comment above #271 (comment) for dark theme.

And brave-core will have more extensions support. https://brave.com/development-plans-for-upcoming-release/

@adambaybutt
Copy link

+1

not going blind is cool...

@superherointj
Copy link

How do I enable Dark mode in Brave?

@JonnyRedHed
Copy link

There is no dark mode UI to enable. Not yet at least, thats the whole point of this request thread.

@millette
Copy link

You enable it with your mind! :-)

@tildelowengrimm
Copy link

We have a dark UI working right now in the Chromium-based Brave refactor! It doesn't cover tasks like changing the color-palettes of sites, but there's also wide extension support which includes Dark Reader or similar tools. We're not going to continue any work on this within the current Muon-based builds. The dark theme should be easy on your eyes soon enough.

@bsclifton
Copy link
Member

bsclifton commented Aug 24, 2018

Screenshot of the Dark theme in action in brave-core:
screen shot 2018-08-24 at 2 53 36 pm

@JonnyRedHed
Copy link

JonnyRedHed commented Aug 25, 2018

So this is work in progress, to be released at a later time.

@tomlowenthal you mention, 'but there's also wide extension support which includes Dark Reader or similar tools.'. Is this available now or coming up soon. When you say similar tools do you mean the extension Stylus? I have 150 Stylus styles I use across browsers, and would love to load them into Stylus on Brave browser.

Am very much a dark webpage user. I currently use the dark website extension called 'Care your Eyes', as it gives a nice dark brown hue to webpages.

If you have followed the Opera browser devs they have been working hard on correcting the tab bar for lots of website icons. Either they are seeing these stats reported by the browser or just working thru a list of the webs most visited websites. I'm guessing from stats reporting in browsers with those users who have it turned on. They have been better matching the dark mode UI with fav icons, either replacing the fav icons or working on the edge aliasing effects for them so they stand out better.

I assume Brave devs will also be doing this.

Also with this latest Opera version https://blogs.opera.com/desktop/2018/08/opera-55-0-2994-44-stable-update/ they have migrated over the dark mode for the settings page from the dev browser. Along with some pop-up warning windows in dark mode.

Also the stable channel release also has the update and recovery page in dark mode. And they are actively working on the webpage right click context menu, and other drop down menus all being dark when the main dark mode UI is turned on. All looking very good so far. Opera, Brave and Vivaldi should be among the best browsers having full on dark mode UI's.

Keep up the good work!

@JonnyRedHed
Copy link

Shouldn't this be left open, for further comment by users.

@bsclifton
Copy link
Member

@JonnyRedHed it's experimental at the moment, but you can try the new Brave here:
https://github.com/brave/brave-browser/releases

We're working hard on getting this ready for Beta. Let us know what you think 😄

@JonnyRedHed
Copy link

I couldn't get BraveBrowserDevSetup.exe to install.

@srirambv
Copy link
Collaborator

@JonnyRedHed Could you please log an issue in https://github.com/brave/brave-browser/issues and provide as much details as possible so that we can find out the root cause

@brave brave locked and limited conversation to collaborators Aug 27, 2018
@tildelowengrimm
Copy link

Any future work in this direction will be in brave-browser. Nothing else is going to change in the current Muon-based Brave. The updated Chromium-based Brave will have:

  • a dark browser theme available by default
  • support for various extensions which change site appearance

Further discussion on this topic should head over to the community forum.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. initiative/ux-harmonization product/user-happiness suggestion usability
Projects
None yet
Development

No branches or pull requests