Bravery global/site settings on about:preferences

[luixxiul]

Describe the issue you encountered: When you select Bravery global/site settings from menubar on about:preferences, a new tab is opened

Expected behavior: It should open about:preferences#shields in the same tab

• Platform (Win7, 8, 10? macOS? Linux distro?): Windows 7
• Brave Version: 0.11.2 Beta1
• Steps to reproduce:
  1. Open about:preferences
  2. Select bravery global or site settings from menubar
• Screenshot if needed:
• Any related issues: Manual tests for Win-x64 0.11.2 Beta1 #2768 Manual tests for Win-x64 0.11.2 Beta2 #2862

[bbondy]

This is related to handling with the singleFrame: true option I believe. It should get the base URL without the #shields and consider it a same frame.

To get started:
git grep getBaseUrl (js/lib/appUrlUtil.js)
git grep singleFrame

[luixxiul]

I think this is no longer valid (Bravery global/site settings has been removed from menubar). Closing.