Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab preview animation on Windows 7 and Windows 10 #2869

Closed
luixxiul opened this issue Aug 2, 2016 · 8 comments · Fixed by #12565
Closed

Tab preview animation on Windows 7 and Windows 10 #2869

luixxiul opened this issue Aug 2, 2016 · 8 comments · Fixed by #12565

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 2, 2016

Test plan

  1. Launch Brave on Windows and open a few tabs
  2. Ensure tab preview is enabled
  3. Use mouse to do a tab preview
  4. Confirm animation takes place while doing the preview (it should gradually fade in)

Original issue description

Describe the issue you encountered: Tab preview animation seems to be not working properly on Windows 7. It shows the preview on hover. Tested on VM.

tabpreview

Expected behavior:

@srirambv
Copy link
Collaborator

srirambv commented Aug 2, 2016

Tested on Desktop running Windows 7 Prof. There is a very little blur effect in tab preview but not as prominent as in VM.

@luixxiul luixxiul changed the title Tab preview animation on Windows 7 Tab preview animation on Windows 7 and Windows 10 Aug 2, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 2, 2016

This can be reproduced on Win10 VM. Maybe this should be labelled wontfix.

@cezaraugusto
Copy link
Contributor

Confused here. Did you tested after #2817 being merged? What should be the expected result?

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 2, 2016

@cezaraugusto I tested it on 0.11.2 Beta2 and think it has been merged. The problem I think is that when I hover the tab preview is displayed at that moment, and then, the tab starts brightening and darkening.

@cezaraugusto
Copy link
Contributor

I had to change transitions to fix the flickering tab issue, maybe it's what you're seeing. Needs a little polish tho. I'll check with Brad how can we improve it.

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Aug 2, 2016

@cezaraugusto your last video looked much smoother. Strange.

Basically, the tabs are not cross-fading. At one point you had them crossfading with the active tab showing in the middle of the sequence.

I was not able to preview any of your changes after that feedback.

image

There may be a problem in the structure that prevents the above approach?

@cezaraugusto
Copy link
Contributor

@bradleyrichter it's like we talked on chat. :)

Assigning it to myself until I polish tab transitions.

@cezaraugusto cezaraugusto self-assigned this Aug 2, 2016
@cezaraugusto cezaraugusto removed their assignment Jun 26, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@petemill petemill mentioned this issue Jan 19, 2018
10 tasks
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.21.x (Beta Channel) Feb 14, 2018
@bsclifton bsclifton modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 20, 2018
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@petemill petemill modified the milestones: 0.23.x (Developer Channel), 0.22.x (Beta Channel) Mar 17, 2018
@srirambv
Copy link
Collaborator

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.