Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pressing Esc key activates the URL Bar #2914

Closed
srirambv opened this issue Aug 3, 2016 · 3 comments · Fixed by #3057
Closed

Pressing Esc key activates the URL Bar #2914

srirambv opened this issue Aug 3, 2016 · 3 comments · Fixed by #3057

Comments

@srirambv
Copy link
Collaborator

srirambv commented Aug 3, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Pressing Esc key on a page changes focus to URL Bar (whether hidden or always visible)

Expected behavior:
Standard behavior is F6 should focus to URL. Esc is only used to stop page load.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.11.2 Dev RC1
  • Steps to reproduce:
    1.
    2.
    3.
  • Screenshot if needed:
  • Any related issues:
@bridiver
Copy link
Collaborator

bridiver commented Aug 5, 2016

escape should revert any typing, focus and select the urlbar if the urlbar is already active, but agree that it shouldn't happen at other times

@luixxiul
Copy link
Contributor

it looks like this has regressed at some timing.

https://community.brave.com/t/escape-key-should-remove-focus-from-address-bar/4736?u=suguru

Using the escape key as a means to remove focus from the address bar seems to be standard across other browsers.

The full functionality is typically:

  • First press: restores the URL of the page (if modified). This is currently working in Brave.
  • Second press: restores focus to the page from the Address Bar.

@bridiver
Copy link
Collaborator

@luixxiul the second press would be very odd behavior imo and no browser that I tested had that behavior, but the there is a problem with the behavior. The first press should clear any autocomplete suggestions and the second should restore the original URL. In the current release the first press restores the original url which is actually very annoying behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants