This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Bookmarked history entries now show context menu in about:history #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (tags.size > 0 && !tag) { | ||
| // If called without tags BUT entry has tags, null out lastAccessedTime. | ||
| // This is a bookmark entry that we want to clear history for (but NOT delete/untag bookmark) | ||
| return sites.setIn([index, 'lastAccessedTime'], null) |
There was a problem hiding this comment.
hah I was going to suggest that as the fix, thanks.
|
++ |
|
I don't think this is a complete fix. We are sending everything in |
|
The sites are the last 500 history we keep, when last access time is defined, but there's a follow up for it as a micro optimization to exclude those. |
This was referenced Aug 25, 2016
This was referenced Aug 25, 2016
This was referenced Aug 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.Fixes #3330