Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

don't send unnecessary ipc messages #3393

Merged
merged 1 commit into from
Aug 25, 2016
Merged

don't send unnecessary ipc messages #3393

merged 1 commit into from
Aug 25, 2016

Conversation

bridiver
Copy link
Collaborator

auditors: @bbondy

darkdh
darkdh reviewed Aug 25, 2016
View reviewed changes
js/about/aboutActions.js
@@ -173,7 +214,10 @@ const AboutActions = {
* @param {object} card - credit card to remove as per doc/state.md's autofillCreditCardDetail
*/
removeAutofillCreditCard: function (card) {
ipc.send(messages.REMOVE_AUTOFILL_CREDIT_CARD, card)
AboutActions.dispatchAction({
actionType: AppConstants.APP_REMOVE_CREDIT_CARD,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be APP_REMOVE_AUTOFILL_CREDIT_CARD

@bridiver
Copy link
Collaborator Author

this takes care of a lot of the low-hanging fruit, but there is still a lot more cleanup to do

@bbondy bbondy merged commit f0b4e27 into master Aug 25, 2016
@luixxiul luixxiul added this to the 0.11.6dev milestone Aug 25, 2016
This was referenced Aug 25, 2016
Closed
Closed
This was referenced Aug 25, 2016
Closed
Closed
Closed
Closed
Closed
@alexwykoff
Copy link
Contributor

from #testers :

yea, we should test that the functionality still works correctly. Basically all the pink sections in app/index.js
setting change, site setting change, resource enabled, move bookmark, delete password and remove autofill address/credit card
I checked most of them, but only on mac
change setting would be most preferences. site setting would be brave menu settings
I believe resource enabled would be things like ad blocking at the global level (edited)
others should be self explanatory

Changes from app/index.js:

  1. messages.CHANGE_SETTING
  2. messages.CHANGE_SITE_SETTING
  3. messages.REMOVE_SITE_SETTING
  4. messages.SET_RESOURCE_ENABLED
  5. messages.MOVE_SITE
  6. messages.DELETE_PASSWORD
  7. messages.DELETE_PASSWORD_SITE
  8. messages.CLEAR_PASSWORDS
  9. messages.REMOVE_AUTOFILL_ADDRESS
  10. messages.REMOVE_AUTOFILL_CREDIT_CARD

This was referenced Aug 31, 2016
Closed
Closed
@aekeus aekeus mentioned this pull request Aug 31, 2016
Closed
@bbondy bbondy deleted the about-actions branch September 23, 2016 00:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
QA/test-plan-specified
Projects
None yet
Milestone
0.11.6dev
Development

Successfully merging this pull request may close these issues.
5 participants
@bridiver @alexwykoff @bbondy @darkdh @luixxiul