Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add styling to make "Merge Favorites" appear aligned (in Import Bookmark modal) #4152

Closed
srirambv opened this issue Sep 21, 2016 · 5 comments
Closed

Add styling to make "Merge Favorites" appear aligned (in Import Bookmark modal) #4152

srirambv opened this issue Sep 21, 2016 · 5 comments
Assignees
@bradleyrichter
Labels
design A design change, especially one which needs input from the design team.

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Merge Favourite into bookmark not properly aligned in Import Bookmark modal

Expected behavior:
Should be properly aligned

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.2 RC1
  • Steps to reproduce:
    1. Open preferences, Click on Import Bookmarks
    2. Merge Favourite into Bookmark is not properly aligned
      3.
  • Screenshot if needed:
    image
  • Any related issues:
    cc: @darkdh
@srirambv srirambv added this to the 0.12.2dev milestone Sep 21, 2016
@darkdh
Copy link
Member

darkdh commented Sep 22, 2016 •
edited
Loading

This is intended because it is the sub option of importing bookmark.
Maybe we need other way to present the sub option, @bradleyrichter?

@bbondy bbondy removed this from the 0.12.2dev milestone Sep 22, 2016
@luixxiul luixxiul closed this as completed Feb 1, 2017
@bradleyrichter
Copy link
Contributor

This will be improved soon:

image

@bsclifton
Copy link
Member

Let's reopen and use this to track the change @bradleyrichter has shown 😄

@bsclifton bsclifton reopened this Feb 1, 2017
@bsclifton bsclifton changed the title Merge Favourite into bookmark not properly aligned in Import Bookmark modal Add styling to make "Merge Favorites" appear aligned (in Import Bookmark modal) Feb 1, 2017
@bsclifton bsclifton added design A design change, especially one which needs input from the design team. and removed invalid labels Feb 1, 2017
@bradleyrichter
Copy link
Contributor

@cezaraugusto just made a new, smaller switch style so we only need the "L"...

@luixxiul
Copy link
Contributor

Closing this in favor of #7194, 46e3919

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradleyrichter bradleyrichter

Labels
design A design change, especially one which needs input from the design team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bbondy @luixxiul @bsclifton @darkdh @bradleyrichter @srirambv