Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Browser 0.12.3 RC3 on Windows periodically becomes unresponsive to clicks after load #4391

Closed
aekeus opened this issue Sep 29, 2016 · 8 comments

Comments

@aekeus
Copy link
Member

aekeus commented Sep 29, 2016

Did you search for similar issues before submitting this one?

Yes, seems to be related to #3231

Describe the issue you encountered:

Periodically after launching the browser, the close button and right click on the Bookmarks toolbar become inoperable. The following error is in the console.

screen shot 2016-09-29 at 6 53 26 pm

The error message is repeatedly reported on all mouse movement events in all open tabs, as well as on a close button press.

no-close

  • Platform (Win10):
  • Brave Version: 0.12.3
  • Steps to reproduce:
    1. This is reproducible on only a fraction of the launch attempts (~10%)

cc @bbondy @bridiver @bsclifton

@bridiver
Copy link
Collaborator

there is a good chance that error message is unrelated. It happens frequently since upstream made a change to the remote api. If you see it happen as a directly result of some action then it might be related

@bridiver
Copy link
Collaborator

actually in this case it might be related because line 191 is an emit for a sync ipc call

@aekeus
Copy link
Member Author

aekeus commented Sep 29, 2016

The error message is triggered each time the mouse is moved over the tab when the browser is in the described state. It is not sent to the console in normal browser operation.

@bridiver
Copy link
Collaborator

is this windows only?

@aekeus
Copy link
Member Author

aekeus commented Sep 29, 2016

Yes, I can only trigger it on Windows 10.

@bsclifton bsclifton changed the title Browser 0.11.3 RC3 on Windows periodically becomes unresponsive to clicks after load Browser 0.12.3 RC3 on Windows periodically becomes unresponsive to clicks after load Sep 30, 2016
@bbondy
Copy link
Member

bbondy commented Sep 30, 2016

This could be the cause, I'm pulling in the commits from upstream electron which has them only in 1.4.1, we're on 1.4.0 upstream.
https://github.com/electron/electron/pull/7209/commits

@bsclifton
Copy link
Member

(just for tracking purposes) It seems issue was first seen with #4380 (comment)

@alexwykoff
Copy link
Contributor

Since this only happened for @aekeus and it was confirmed on his machines, I think the only steps for QA are to check that the common windows interaction items work properly.

If there are other concerns for QA, (like zoom, resolution, etc.) please be sure add a comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants