Autocomplete - wrong website title

[Sh1d0w]

Did you search for similar issues before submitting this one?
No.

Describe the issue you encountered:

Autocomplete yields wrong title for some history entries.

Expected behavior:

The title of the page should match the path of the page.

• Platform (Win7, 8, 10? macOS? Linux distro?): all
• Brave Version: 0.12.5-1
• Steps to reproduce:
  1. Open new blank tab.
  2. Type twitter.com hit enter
  3. Open second tab start typing twitter verify that the title is correct.
  4. Now close the second tab and in the first opened tab with twitter, click on a feed post
  5. Notice that the url and the title changes
     6 .Again open a new tab and start typing twitter
  6. Observe that the title is wrong
• Screenshot if needed:
  
• Any related issues:
  Hidden history entries appear by deleting the latest entry #4224
  URL bar sometimes shows a part of domain #4663

[bbondy]

I assume this is a sites entry that has the wrong title, can you check in session-store-1 in your brave user profile dir?
If that's it, do you have STR to get one oft hose site entries?

[Sh1d0w]

@bbondy This is very easy reproducible.

1. Open new blan tab.
2. Type twitter.com hit enter
3. Open second tab start typing twitter verify that the title is correct.
4. Now close the second tab and in the first opened tab with twitter, click on a feed post so a popup appears and you can preview the comments
5. Notice that the url and the title changes
6. Again open a new tab and start typing twitter
7. Observe that the title for the main domain twitter.com is wrong

I even know why it is happening. It is because of this line:

https://github.com/brave/browser-laptop/blob/master/js/components/frame.js#L698

Here you update the page title, but in this case I think the history entry should not be updated unless you monitor the URL change as well? I think Brave is not handling historyPopState correctly.

[dhaneshsabane]

Wasn't able to reproduce this bug on Fedora.

[bsclifton]

Removing milestone for now. Let's chat if you'd like to see this be bumped up in priority. Thanks 😄

[garrettr]

I can reproduce this on Mac OS 10.10.5 with Brave 0.12.15. I noticed it when auto-completing entries with fuzzy matching in the address bar. The fuzzy-match query would correctly match against the URL, but the correct title for the matched URL would not be displayed.

Here's an example screenshot—notice that the titles don't match the URLs for the first two history entries:

[bsclifton]

This appears to have been fixed- I can't reproduce with the steps mentioned

[luixxiul]

I cannot find a proper STR but I experience the issue on Windows. I notice it on youtube especially, wondering if it could be related with youtube autoplay.