Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix auto-suggest sort order with different protocol prefixes #5091

Closed
aekeus opened this issue Oct 24, 2016 · 0 comments · Fixed by #5092
Closed

Fix auto-suggest sort order with different protocol prefixes #5091

aekeus opened this issue Oct 24, 2016 · 0 comments · Fixed by #5092
Assignees
@aekeus
Labels
QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.7dev

Comments

@aekeus
Copy link
Member

aekeus commented Oct 24, 2016 •
edited
Loading

  • Auto-complete history was not correctly ordering items with a mix of http:// and https:// prefix
  • Too few history items where being shown
  • Steps to reproduce:
    1. Visit a mixture of sites that have a similar name (twitter.com, twilio.com) but have a different protocol prefix (http, https)
    2. Locations with different prefixes will be sorted together regardless of visit count or last access

Related: #5067

cc @bbondy @bradleyrichter @Sh1d0w
@aekeus aekeus added this to the 0.12.7dev milestone Oct 24, 2016
@aekeus aekeus self-assigned this Oct 24, 2016
aekeus added a commit that referenced this issue Oct 24, 2016
@aekeus
Handle different protocol prefixes in auto-suggest
f7324ca 
  * Remove http and https from URLs when sorting
  * Increase history limit to 3, suggested to 3
  * Update unit tests

Auditors: @bbondy

Test Plan:

  1. Visit a mixture of sites that have a similar name (twitter.com, twilio.com) but have a different protocol prefix (http, https)
  2. Ensure that history sorting is entirely based on count and frequency
  3. Ensure that a maximum of 3 history items and 3 suggested sites are shown (so as not to overflow the space available and cause a scrollbar to appear)

Fixes: #5091
@aekeus aekeus mentioned this issue Oct 24, 2016
Merged
4 tasks
This was referenced Oct 26, 2016
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Oct 26, 2016
Closed
This was referenced Oct 27, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 28, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aekeus aekeus

Labels
QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.7dev
Development

Successfully merging a pull request may close this issue.

Handle different protocol prefixes in auto-suggest brave/browser-laptop
4 participants
@aekeus @alexwykoff @luixxiul @srirambv