Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor payment/history.js #8037

Closed
luixxiul opened this issue Apr 2, 2017 · 3 comments
Closed

Refactor payment/history.js #8037

luixxiul opened this issue Apr 2, 2017 · 3 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 2, 2017

Test plan

#8038 (comment)


Describe the issue you encountered:
Refactor payment/history.js

The payment history should be styled like this based on #6047 (comment):

screenshot 2016-12-15 3 36 37

The original mockup provided by @bradleyrichter is available here: #6202

Currently:
screenshot 2017-04-02 18 13 47

@luixxiul luixxiul added feature/rewards polish Nice to have — usually related to front-end/visual tasks. refactoring labels Apr 2, 2017
@DivineOmega
Copy link

Would it make sense to right align the monetary values in the second column? This would ensure the decimal points line up and possibly make it easier to skim read the values.

@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 3, 2017

I could try like this:

screenshot 2017-04-03 13 26 21

Yet it seems difficult to align the columns to the label (Total Amount), in terms of localization. I don't have a good idea for that

@bbondy
Copy link
Member

bbondy commented May 26, 2017

btw for refactors please always mark as release-notes/exclude

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants