Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move navigation logic into new component #8189

Closed
NejcZdovc opened this issue Apr 10, 2017 · 1 comment
Closed

Move navigation logic into new component #8189

NejcZdovc opened this issue Apr 10, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 10, 2017 •
edited by luixxiul
Loading

Test plan

#8205 (comment)

Describe the issue you encountered:
Move logic related to top navigation out of main.js file into new component. This way it will be ready for redux component pattern
@NejcZdovc NejcZdovc self-assigned this Apr 10, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 10, 2017
@NejcZdovc
Moves navigation logic from main.js to new component
5aea176 
Resovles brave#8189

Auditor: @bridiver
@NejcZdovc NejcZdovc mentioned this issue Apr 10, 2017
Closed
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 10, 2017
@NejcZdovc
Moves navigation logic from main.js to new component
633a2aa 
Resovles brave#8189

Auditor: @bridiver
@NejcZdovc NejcZdovc mentioned this issue Apr 10, 2017
Merged
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 11, 2017
@NejcZdovc
Moves navigation logic from main.js to new component
67c3f1e 
Resovles brave#8189

Auditor: @bridiver
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 11, 2017
@NejcZdovc
Moves navigation logic from main.js to new component
dccc4a0 
Resovles brave#8189

Auditor: @bridiver
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 12, 2017
@NejcZdovc
Moves navigation logic from main.js to new component
276bef9 
Resovles brave#8189

Auditor: @bridiver
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 12, 2017
@NejcZdovc
Moves navigation logic from main.js to new component
1cdaaf3 
Resovles brave#8189

Auditor: @bridiver
@NejcZdovc
Copy link
Contributor Author

closed via 1cdaaf3

@luixxiul luixxiul added this to the 0.15.3 milestone May 8, 2017
This was referenced May 23, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @NejcZdovc @srirambv