Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove ref dependency from Frame #8322

Closed
NejcZdovc opened this issue Apr 14, 2017 · 2 comments
Closed

Remove ref dependency from Frame #8322

NejcZdovc opened this issue Apr 14, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 14, 2017 •
edited
Loading

Test plan

#8336 (comment)

Describe the issue you encountered:
Because Frame will now be a stateless component, we need to remove dependency on refs from a Frame
@NejcZdovc NejcZdovc added this to the 0.14.3 milestone Apr 14, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 14, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 14, 2017
@NejcZdovc
Remove ref dependency from Frame
3dd46d3 
Resolves brave#8322

Auditors: @bsclifton @bridiver

Test Plan:
- tests are green
@NejcZdovc NejcZdovc mentioned this issue Apr 15, 2017
Merged
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2017
@NejcZdovc
Remove ref dependency from Frame
1b0713a 
Resolves brave#8322

Auditors: @bsclifton @bridiver

Test Plan:
- tests are green
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2017
@NejcZdovc
Remove ref dependency from Frame
b6f6b6e 
Resolves brave#8322

Auditors: @bsclifton @bridiver

Test Plan:
- tests are green
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2017
@NejcZdovc
Remove ref dependency from Frame
5876329 
Resolves brave#8322

Auditors: @bsclifton @bridiver

Test Plan:
- tests are green
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 19, 2017
@NejcZdovc
Remove ref dependency from Frame
f81695d 
Resolves brave#8322

Auditors: @bsclifton @bridiver

Test Plan:
- tests are green
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 19, 2017
@NejcZdovc
Remove ref dependency from Frame
24b5036 
Resolves brave#8322

Auditors: @bsclifton @bridiver

Test Plan:
- tests are green
NejcZdovc added a commit that referenced this issue Apr 19, 2017
@NejcZdovc
Merge pull request #8336 from NejcZdovc/hotfix/#8322-refs
22dc2b2 
Remove ref dependency from Frame
This was referenced May 2, 2017
Closed
Closed
@luixxiul
Copy link
Contributor

luixxiul commented May 20, 2017 •
edited
Loading

@NejcZdovc if you think this is not worth mentining in relase notes, would you mind removing the label that I have added in case? CC @alexwykoff

@NejcZdovc
Copy link
Contributor Author

Yeah I think that we can remove it from release notes

This was referenced May 23, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @NejcZdovc @srirambv