Notification bar is still visible after restart

[NejcZdovc]

• Did you search for similar issues before submitting this one?
  yes

• Describe the issue you encountered:
  Notification bar is still visible after restart

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS

• Brave Version (revision SHA):
  570587f

• Steps to reproduce:

  1. go to about:preferences#extensions
  2. disable PDF viewer (notification about restart is shown)
  3. restart your browser by clicking on a X
  4. start your browser again

• Actual result:
  Notification is still visible

• Expected result:
  Notification shouldn't be visible, because you just restarted your browser

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  yes

• Is this an issue in the currently released version?

• Can this issue be consistently reproduced?
  yes

[luixxiul]

Is this specific to the extension pane ie after changing the lang setting as well?

[NejcZdovc]

didn't test with the language

[cezaraugusto]

which X should I click? I hit "yes" to restart but couldn't reproduce. Notification was hidden as expected.

Running SHA 506036e, macOS Sierra.

[NejcZdovc]

@cezaraugusto X as in aplication X 😃 don't click anything on the notification

[cezaraugusto]

ok I think that's because window closing on Mac isn't necessarily a restart. Unless you cmd+q to close, window will be refreshed but app is not restarted. That would work with Win/Linux where close icon really means closing the app, but not on mac.

You could check that by disabling webtorrent and closing with the X, then try to download a torrent. On restart, notification is still active (bug per this issue) but that's because webtorrent is still active, since clicking on the download file would redirect to webtorrent page. So notification is still on because extension is still on -- until you restart.

[cezaraugusto]

btw there's a conditional in our code indicating that behavior on mac here: https://github.com/brave/browser-laptop/blob/master/app/index.js#L235

you can see that app will quit on all OSes except darwin (mac)

[alexwykoff]

working as designed see above ^

[srirambv]

I am not able to verify this on Win x64 preview 2 due to #8629. Tried building it from source and packaged build.

[NejcZdovc]

@srirambv this is invalid. It's working as designed.