Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Browser background process continues to run after closing the browser window #8629

Closed
srirambv opened this issue May 2, 2017 · 10 comments
Closed

Browser background process continues to run after closing the browser window #8629

srirambv opened this issue May 2, 2017 · 10 comments
Assignees
@bsclifton
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 2, 2017 •
edited
Loading

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Browser background process continues to run after closing the browser window

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

  • Steps to reproduce:

    1. Clean install 0.15.2 Preview 2
    2. Wait for the browser window to show up and open task manager
    3. Close the window, check task manager all process is still running
    4. Open console and try to launch browser
    5. Shows error as process is locked
    6. Kill all process and launch from console, browser starts

  • Actual result:
    Browser background process continues to run after closing the browser window

  • Expected result:
    Should close all background process once window is closed

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    p2

  • Any related issues:
@srirambv srirambv added this to the 0.15.2 milestone May 2, 2017
@bsclifton bsclifton mentioned this issue May 2, 2017
Closed
@luixxiul
Copy link
Contributor

luixxiul commented May 3, 2017

This can be reproduced on debian

@bsclifton
Copy link
Member

@srirambv @luixxiul this should have always been a bug. Can you please confirm it happens on older releases? If so, it's a bad bug, but I don't think it's a blocker

@luixxiul
Copy link
Contributor

luixxiul commented May 3, 2017

the thing is you cannot restart the browser on debian unless you manually kill the process.

@srirambv
Copy link
Collaborator Author

srirambv commented May 3, 2017

@bsclifton I verified it from 0.13.3 onward, its not an issue. Its only in this build. It works fine in the preview 1 build which was removed.

@srirambv srirambv mentioned this issue May 3, 2017
Closed
@bsclifton
Copy link
Member

bsclifton commented May 3, 2017 •
edited
Loading

@srirambv this is great info- thanks for confirming 😄

Based on your findings, this is indeed a blocker 😄

@alexwykoff alexwykoff modified the milestones: 0.15.4, 0.15.3 May 5, 2017
@luixxiul
Copy link
Contributor

luixxiul commented May 6, 2017 •
edited
Loading

This should be a blocker for 0.15.3, not 0.15.4 right?

@luixxiul luixxiul modified the milestones: 0.15.3, 0.15.4 May 6, 2017
@luixxiul
Copy link
Contributor

luixxiul commented May 6, 2017

This remains an issue on the latest preview on Debian.

@luixxiul
Copy link
Contributor

luixxiul commented May 7, 2017

Findings:

1 - Close the window by closing all of the tabs -> process remains
2 - Close via main menu -> process closed

So I'm wondering if it is related with the tab close handling. Also might be related with: #8740

@bsclifton
Copy link
Member

Confirmed- this is a really bad one ☹️

@bsclifton
Copy link
Member

bsclifton commented May 10, 2017 •
edited
Loading

I've confirmed this is not fixed with #8782.

However, I did narrow down the root cause. It's happening when you close the window using the X button on the top right (or picking File > Close), versus using Ctrl + Q (or picking File > Quit from menu). Will look at a fix now

bsclifton added a commit that referenced this issue May 11, 2017
@bsclifton
saveAppState needs to be called to perform the quit (was only missing…
01e62d6 
… from the lastWindowClosed case)

Unintentionally introduced with 40abc0c#diff-2018087f584c4398b5c3a23fc0e5f9dbR172
True needs to be passed, because the last known window state is saved, so receivedAllWindows is always false

Fixes #8629

Auditors: @bridiver
@bsclifton bsclifton mentioned this issue May 11, 2017
Merged
6 tasks
bsclifton added a commit that referenced this issue May 11, 2017
@bsclifton
saveAppState needs to be called to perform the quit (was only missing…
869c0aa 
… from the lastWindowClosed case)

Unintentionally introduced with 40abc0c#diff-2018087f584c4398b5c3a23fc0e5f9dbR172
True needs to be passed, because the last known window state is saved, so receivedAllWindows is always false

Fixes #8629

Auditors: @bridiver
This was referenced May 23, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @bsclifton @srirambv