Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Saving a page/torrent file crashes browser #8648

Closed
luixxiul opened this issue May 3, 2017 · 7 comments
Closed

Saving a page/torrent file crashes browser #8648

luixxiul opened this issue May 3, 2017 · 7 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 3, 2017

Test plan

  1. Save a page via shortcut key
  2. Click "Save" on save dialog

Describe the issue you encountered: Saving a page/torrent file crashes the browser

  • Platform (Win7, 8, 10? macOS? Linux distro?): Debian (confirmed on Windows 10 32 bit)

  • Brave Version (revision SHA): 0.15.2 preview 2

  • Steps to reproduce:

    1. Save a page via shortcut key
    2. Click "Save" on save dialog
  • Actual result: the browser crashes

  • Expected result: the browser should not crash

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added this to the 0.15.2 milestone May 3, 2017
@luixxiul luixxiul changed the title Saving a page crashes browser Saving a page/torrent file crashes browser May 3, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented May 3, 2017

The browser crashes when you save torrent files via "save torrent file" button.

@NejcZdovc
Copy link
Contributor

 @luixxiul is this working correctly on 0.15.1?

@luixxiul
Copy link
Contributor Author

luixxiul commented May 3, 2017

yes

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 3, 2017

Probably related to #8567

cc @feross

@luixxiul
Copy link
Contributor Author

luixxiul commented May 3, 2017

Probably related to #8567

I don't think so because the browser crashes when saving a web page as I reported.

@luixxiul luixxiul modified the milestones: 0.15.2, 0.15.3 May 4, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented May 4, 2017

I think this has been fixed with the latest build. CC @srirambv for confirmation.

@alexwykoff alexwykoff modified the milestones: 0.15.3, 0.15.2 May 4, 2017
@alexwykoff
Copy link
Contributor

pretty sure this works

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.