Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

switch from node-uuid to uuid #8667

Closed
diracdeltas opened this issue May 3, 2017 · 0 comments · Fixed by #8668
Closed

switch from node-uuid to uuid #8667

diracdeltas opened this issue May 3, 2017 · 0 comments · Fixed by #8668
Assignees
@diracdeltas
Labels
QA/checked QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 3, 2017 •
edited by luixxiul
Loading

Test plan

  1. rm -rf node_modules
  2. npm i
  3. npm run watch
  4. npm start

we currently use node-uuid for browser-laptop and uuid for tests, but actually the two projects are merged into uuid now. https://www.npmjs.com/package/node-uuid
@diracdeltas diracdeltas added this to the 0.15.3 milestone May 3, 2017
@diracdeltas diracdeltas self-assigned this May 3, 2017
diracdeltas added a commit that referenced this issue May 3, 2017
@diracdeltas
switch from node-uuid to uuid
2ff7918 
fix #8667

Test Plan:
N/A
@diracdeltas diracdeltas mentioned this issue May 3, 2017
Merged
4 tasks
This was referenced May 5, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

switch from node-uuid to uuid brave/browser-laptop
3 participants
@diracdeltas @alexwykoff @luixxiul