Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Importer warning doesn't work #8846

Closed
darkdh opened this issue May 12, 2017 · 1 comment · Fixed by #8864
Closed

Importer warning doesn't work #8846

darkdh opened this issue May 12, 2017 · 1 comment · Fixed by #8864
Assignees
@darkdh
Labels
bug feature/importer QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@darkdh
Copy link
Member

darkdh commented May 12, 2017 •
edited by luixxiul
Loading

Test plan

#8864 (comment)

STR:

  1. Open firefox
  2. Open Brave and import from firefox
  3. There should be a warning dialog

Caused by brave/muon@d534ffd

CC @bridiver
@darkdh darkdh added this to the 0.15.300 milestone May 12, 2017
@darkdh darkdh self-assigned this May 12, 2017
@darkdh
Copy link
Member Author

darkdh commented May 12, 2017

Yes, for tracking

@luixxiul luixxiul added the bug label May 12, 2017
darkdh added a commit that referenced this issue May 13, 2017
@darkdh
Handle show-warning-dialog event on app
2ff2773 
requires brave/muon#196

fix #8846

Auditors: @bridiver, @bbondy

Test Plan:
1. Open Firefox
2. Open Brave and import from Firefox
3. There will be a warning window
@darkdh darkdh mentioned this issue May 13, 2017
Merged
6 tasks
bsclifton pushed a commit that referenced this issue May 16, 2017
@darkdh @bsclifton
Handle show-warning-dialog event on app
e01b081 
requires brave/muon#196

fix #8846

Auditors: @bridiver, @bbondy

Test Plan:
1. Open Firefox
2. Open Brave and import from Firefox
3. There will be a warning window
This was referenced May 23, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/importer QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

Handle show-warning-dialog event on app brave/browser-laptop
4 participants
@alexwykoff @luixxiul @darkdh @srirambv