Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Selecting URL with right arrow key from the pulldown on URL bar re-selects the 1st entry #8899

Closed
luixxiul opened this issue May 17, 2017 · 6 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 17, 2017

Test plan

  1. Open https://github.com
  2. Open several pages from the menu
  3. Close the tabs
  4. Input github to URL bar
  5. Hit down arror key
  6. Try selecting a URL from the pulldown with right arrow key

Describe the issue you encountered: Selecting URL with right arrow key from the pulldown on URL bar re-selects the 1st entry.

autocomplete

  • Platform (Win7, 8, 10? macOS? Linux distro?): debian

  • Brave Version (revision SHA): 0.15.304

  • Actual result: the 1st URL is always re-selected

  • Expected result:

  • Is this an issue in the currently released version?
    No. The issue cannot reproduced on .300. I tried .303 and it can be reproduced.

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added this to the 0.15.300 milestone May 17, 2017
@bsclifton
Copy link
Member

bsclifton commented May 17, 2017

reproduced on dev-channel (which is just a bit ahead of .304). Will look into this
(may be related to #8865 or the fix)

@bsclifton bsclifton self-assigned this May 17, 2017
@bsclifton bsclifton removed this from the 0.15.300 milestone May 17, 2017
@bsclifton bsclifton removed their assignment May 17, 2017
@bsclifton
Copy link
Member

Removing milestone and closing as a duplicate of #5767

@bsclifton bsclifton added duplicate Issue has already been reported and removed regression labels May 17, 2017
@bsclifton
Copy link
Member

removed regression tag also, as this has been an issue for a while

@luixxiul
Copy link
Contributor Author

luixxiul commented May 18, 2017

I don't think this is the duplicate. This time with right arrow key you cannot select nothing than the 1st item. Here's a better STR:

  1. Visit github.com
  2. Visit github.com/Selecting URL with right arrow key from the pulldown on URL bar re-selects the 1st entry #8899#issuecomment-302233759
  3. Input github.com
  4. From the autocomplete list, select github.com/Selecting URL with right arrow key from the pulldown on URL bar re-selects the 1st entry #8899#issuecomment-302233759 with down arrow key
  5. Hit right arrow key

Expected result: github.com//issues/8899#issuecomment-302233759 should be selected

Actual result; github.com (1st item) is re-selected

@luixxiul luixxiul reopened this May 18, 2017
@luixxiul
Copy link
Contributor Author

CC @srirambv for reproduction

@luixxiul luixxiul removed the duplicate Issue has already been reported label May 18, 2017
@luixxiul luixxiul added this to the 0.15.300 milestone May 18, 2017
@bbondy
Copy link
Member

bbondy commented May 18, 2017

This seems to be fixed with my various commits for work on suggestions. Closing but please test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.