Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Browser crashes when maximized and minimized button is click in quick succession #8938

Closed
srirambv opened this issue May 18, 2017 · 0 comments

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Browser crashes when maximized and minimized button is click in quick succession

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.15.305
    rev 2186b3f
    Muon 3.0.104

  • Steps to reproduce:

    1. Clean install .305 build
    2. Launch from console
    3. Click maximize and minimize button in quick succession, browser crashes after 5-6 attempts
    4. Try launching from console again, browser launches and crashes again
    5. Try launching again from console, third times the charm, loads properly
  • Actual result:
    Browser crashes when maximized and minimized button is click in quick succession

  • Expected result:
    Should not crash

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    Console error when browser crashes

An uncaught exception occurred in the main process Uncaught Exception:
TypeError: parsedUrl.query.split is not a function
    at SearchIndex.tokenizeInput (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\app\common\lib\siteSuggestions.js:87:44)
    at C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\bloodhound-js\lib\search_index.js:36:37
    at Array.forEach (native)
    at Object.each (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\bloodhound-js\lib\utils.js:52:16)
    at SearchIndex.add (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\bloodhound-js\lib\search_index.js:32:7)
    at Bloodhound.add (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\bloodhound-js\lib\bloodhound.js:110:16)
    at add (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\app\common\lib\siteSuggestions.js:105:12)
    at urlBarSuggestionsReducer (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\app\browser\reducers\urlBarSuggestionsReducer.js:22:9)
    at reducers.reduce (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\js\stores\appStore.js:376:24)
    at Array.reduce (native)
C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\node-anonize2-relic-emscripten\anonize2-jumbo.js:67
            throw ex
            ^

TypeError: parsedUrl.query.split is not a function
    at SearchIndex.tokenizeInput (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\app\common\lib\siteSuggestions.js:87:44)
    at C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\bloodhound-js\lib\search_index.js:36:37
    at Array.forEach (native)
    at Object.each (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\bloodhound-js\lib\utils.js:52:16)
    at SearchIndex.add (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\bloodhound-js\lib\search_index.js:32:7)
    at Bloodhound.add (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\node_modules\bloodhound-js\lib\bloodhound.js:110:16)
    at add (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\app\common\lib\siteSuggestions.js:105:12)
    at urlBarSuggestionsReducer (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\app\browser\reducers\urlBarSuggestionsReducer.js:22:9)
    at reducers.reduce (C:\Users\Sriram BV\AppData\Local\brave\app-0.15.305\resources\app.asar\js\stores\appStore.js:376:24)
    at Array.reduce (native)
@srirambv srirambv added crash needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. OS/Windows QA/test-plan-specified labels May 18, 2017
@srirambv srirambv added this to the 0.15.300 milestone May 18, 2017
bbondy added a commit that referenced this issue May 18, 2017
Fix #8938

Auditors: @bsclifton

This shouldn't be happening but Sriram got a crash with it, so handling query as an object
@bbondy bbondy closed this as completed in 065b51a May 18, 2017
@luixxiul luixxiul added QA/checked-Linux and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. OS/Windows labels May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.