Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

converting BrowserButton tracking issue #9071

Closed
4 of 5 tasks
luixxiul opened this issue May 26, 2017 · 0 comments
Closed
4 of 5 tasks

converting BrowserButton tracking issue #9071

luixxiul opened this issue May 26, 2017 · 0 comments
Assignees
@cezaraugusto
Labels
misc/button project-tracking refactoring/aphrodite wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 26, 2017 •
edited
Loading

Describe the issue you encountered: converting BrowserButton tracking issue. This is a follow up to #8568

  • Any related issues:
@luixxiul luixxiul added this to the Backlog milestone May 26, 2017
This was referenced May 26, 2017
Closed
Merged
cezaraugusto pushed a commit that referenced this issue May 30, 2017
@cezaraugusto
Add browserButton_subtleItem and fix regressions
f3c503e 
Closes #9072
Addresses #9071

Also:
- Add lines in the same way as LESS files
- Add comments for refenrence (We could remove them after refactoring work)
- Fix regressions on browserButton_default
  - Add globalStyles.button.color to replace it with globalStyles.button.default.color
- Fix a typo

Auditors:

Test Plan 1:
(0. Take a screenshot of the buttons section on about:styles before testing the PR for later use)
1. Open about:styles
2. Click "buttons"
3. Take another screenshot of the section
4. Compare the two screenshots and make sure they look same

Test Plan 2:
1. Open about:styles
2. Toggle developer tools
3. Make sure button's padding is set to '5px 16px'

Test Plan 3:
1. Open downloadme.org
2. Click "Advanced" button
3. Make sure the button is not pushed down
4. Click "Hide advanced" button
5. Make sure the button does not move
@luixxiul luixxiul mentioned this issue Jun 18, 2017
Closed
@luixxiul luixxiul removed this from the Backlog milestone Sep 14, 2017
@luixxiul luixxiul mentioned this issue Sep 14, 2017
Closed
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@luixxiul luixxiul removed their assignment Feb 13, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
misc/button project-tracking refactoring/aphrodite wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luixxiul @cezaraugusto @bsclifton