This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Autoplay notification should be dismissed if user ignores notification and continues stream #9143
Assignees
Labels
feature/autoplay
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/include
Milestone
Comments
srirambv
added
bug/good-first-bug
feature/autoplay
polish
darkdh
added a commit
that referenced
this issue
Jul 27, 2017
fixes #9143 fixes #9008 fixes #9171 Auditors: @bsclifton, @bridiver, @cezaraugusto Test Plan: Covered by automatic test Specific STR for #9171: 1. Turn on autoplay to `always ask` and make sure there is no any allow autoplay permissions 2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification bar 3. Open another tab and go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay and still don't click on notification bar 4. Go back the youtube tab you will find out the notification bar is non clickable 5. Go to the w3schools tab and it will also be non clickable
darkdh
added a commit
that referenced
this issue
Jul 31, 2017
fixes #9143 fixes #9008 fixes #9171 Auditors: @bsclifton, @bridiver, @cezaraugusto Test Plan: Covered by automatic test Specific STR for #9171: 1. Turn on autoplay to `always ask` and make sure there is no any allow autoplay permissions 2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification bar 3. Open another tab and go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay and still don't click on notification bar 4. Go back the youtube tab you will find out the notification bar is non clickable 5. Go to the w3schools tab and it will also be non clickable
This was referenced Dec 20, 2017
darkdh
modified the milestones:
0.20.x (Beta Channel),
0.19.x Hotfix 11 (Release Channel)
|
Clearing flags as this was tested against |
|
Verified on 0.19.126. Clicking play though notification works and video playback starts. |
This was referenced Jan 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
Always AskOriginal issue description
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Autoplay notification should be dismissed if user ignores and choose to play
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
Brave 0.16.0
rev be76cd3
Muon 3.2.101
Steps to reproduce:
Always AskActual result:
Autoplay notification is not dismissed when user ignores and clicks play
Expected result:
Should dismiss notification bar for that video stream when user ignores it
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
No
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
The text was updated successfully, but these errors were encountered: