This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Command+L when in url bar with URL bar suggestion should select full URL #9914
Labels
Milestone
Comments
bbondy
added a commit
that referenced
this issue
Jul 9, 2017
There was also a lot of other fixes which moves things out of the component and into the store. Note that there are no state functions in use yet for the window renderer so I didn't create them yet as part of this task and just used immutableJS directly. I also fixed some intermittents with this fix. Fix #9914 Auditors: @bsclifton Test Plan: 1. Fully test url bar and suggestions thoroughly 2. Type in some chars that lead to a autocomplete selection, press command+L and make sure it selects all text.
8 tasks
bbondy
added a commit
that referenced
this issue
Jul 10, 2017
There was also a lot of other fixes which moves things out of the component and into the store. Note that there are no state functions in use yet for the window renderer so I didn't create them yet as part of this task and just used immutableJS directly. I also fixed some intermittents with this fix. Fix #9914 Auditors: @bsclifton Test Plan: 1. Fully test url bar and suggestions thoroughly 2. Type in some chars that lead to a autocomplete selection, press command+L and make sure it selects all text.
bbondy
added a commit
that referenced
this issue
Jul 10, 2017
There was also a lot of other fixes which moves things out of the component and into the store. Note that there are no state functions in use yet for the window renderer so I didn't create them yet as part of this task and just used immutableJS directly. I also fixed some intermittents with this fix. Fix #9914 Auditors: @bsclifton Test Plan: 1. Fully test url bar and suggestions thoroughly 2. Type in some chars that lead to a autocomplete selection, press command+L and make sure it selects all text.
|
I'd like to get this in 0.7.14 but it would need us to merge PR that I'd like but that needs that is here: |
|
I'll put this in 0.19.x until we figure that out. |
|
My PR is not directly mergeable, we would need to update some properties in |
|
ok let's just wait for this issue then until 0.19.x |
bbondy
added a commit
that referenced
this issue
Jul 10, 2017
There was also a lot of other fixes which moves things out of the component and into the store. Note that there are no state functions in use yet for the window renderer so I didn't create them yet as part of this task and just used immutableJS directly. I also fixed some intermittents with this fix. Fix #9914 Auditors: @bsclifton Test Plan: 1. Fully test url bar and suggestions thoroughly 2. Type in some chars that lead to a autocomplete selection, press command+L and make sure it selects all text.
This was referenced Sep 20, 2017
This was referenced Sep 20, 2017
This was referenced Sep 21, 2017
This was referenced Sep 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
See #9928
Original issue description
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
If you are typing a URL and auto suggest is filling in another URL for you, hitting command+L doesn't select the URL.
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
0.17.14
Steps to reproduce:
Actual result:
Removes the selection
Expected result:
Selects the URL
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes
The text was updated successfully, but these errors were encountered: