Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Normalize action buttons placement #10466

Closed
wants to merge 1 commit into from
Closed

Normalize action buttons placement #10466

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Aug 14, 2017

Move the button left of the input field.
Also replace Button with BrowserButton.

Fixes #10465

The margin between the buttons and the input field will be adjusted with another PR where I'm going to normalize siteDetails.less, so please ignore it for now.

Auditors:

Test Plan:

  1. Open about:history
  2. Open about:bookmarks
  3. Make sure the action buttons are placed left of the input fields

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/about-pages misc/button labels Aug 14, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 14, 2017
@luixxiul luixxiul self-assigned this Aug 14, 2017
Move the button left of the input field.
Also replace Button with BrowserButton.

Fixes #10465

Auditors:

Test Plan:
1. Open about:history
2. Open about:bookmarks
3. Make sure the action buttons are placed left of the input fields
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs margin, history is looking like this for me:
screen shot 2017-09-04 at 8 22 23 pm

@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 7, 2017

Closing this PR for now. The commit to close #10465 will be cherry-picked by another PR later.

@luixxiul luixxiul closed this Sep 7, 2017
@luixxiul luixxiul removed this from the 0.21.x (Nightly Channel) milestone Sep 7, 2017
@luixxiul luixxiul removed the request for review from bsclifton September 7, 2017 03:34
@luixxiul luixxiul deleted the polish-aboutpages-button-alignment branch September 7, 2017 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/about-pages misc/button
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants