Commits on Aug 29, 2017

1. Stop losing pinned tabs in a window when adding or removing another p… …

   …inned tab
   
   Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117
   
   The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.

   

   petemill authored and bsclifton committed Aug 29, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 01008da
   • Browse repository at this point

   Copy the full SHA

   01008da View commit details

   Browse the repository at this point in the history

2. Added unit tests, fixed lint error …

   Auditors: @petemill
   
   Test Plan:
   `npm run unittest -- --grep="window API unit tests"`

   

   bsclifton committed Aug 29, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 4ced9dd
   • Browse repository at this point

   Copy the full SHA

   4ced9dd View commit details

   Browse the repository at this point in the history