This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add 'fitContent' props to browserButton #11202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11201 Only BrowserButton with 'fitContent' props are forced to have the min-width:fit-content. This change is required to apply display:flex to headerActions, as it refers width instead of min-width, even though actual min-width is larger than actual width of the buttons. - Align header items on about:history (fixes #10465) - Polish .searchInput on about:bookmarks and about:history (addresses #10898 and #10899) Auditors: @cezaraugusto Test Plan: 1. Open about:history 2. Open about:bookmarks 3. Make sure the header items are not wrapped Test Plan 2: 1. Open https://expired.badssl.com/ 2. Minimize the window's width 3. Make sure the buttons' text do not overflow
|
CC @srirambv for confirming the fix should work. |
This was referenced Sep 28, 2017
Merged
srirambv
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11201, introduced with #10934
Fixes #11224
Only BrowserButton with 'fitContent' props are forced to have the min-width:fit-content. This change is required to apply display:flex to headerActions, as it refers width instead of min-width, even though actual min-width is larger than actual width of the buttons.
Auditors: @cezaraugusto
Test Plan:
Test Plan 2:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests