This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
18 Unbelievable ways to get rid of dead tabs on tab close #11311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
force-pushed
the
11028
branch
2 times, most recently
from
6fe07c9
to
d2ff410
Compare
This was referenced Oct 6, 2017
bbondy
force-pushed
the
11028
branch
5 times, most recently
from
488f414
to
dc7aedc
Compare
bsclifton
reviewed
Oct 6, 2017
| @@ -184,6 +211,7 @@ const tabsReducer = (state, action, immutableAction) => { | |||
| tabs.setActive(nextActiveTabId) | |||
| } | |||
| }) | |||
| tabs.forgetTab(tabId) | |||
There was a problem hiding this comment.
bsclifton
reviewed
Oct 6, 2017
| const tabsPerPage = Number(getSetting(settings.TABS_PER_PAGE)) | ||
| const startTabIndex = tabPageIndex * tabsPerPage | ||
| const pinnedTabsCount = tabState.getPinnedTabsByWindowId(state, windowId).size | ||
| tabState.getTabsByWindowId(state, windowId) |
There was a problem hiding this comment.
There's a whole bunch happening here- would it make sense to follow up and move this logic into tabState? Like a tabState.getTabsForClose (or similar)
There was a problem hiding this comment.
I think it makes sense but I'm going to pass on it for now since I have other 0.19.x high priority things to focus on, but that's valid minor refactor for sure.
bsclifton
reviewed
Oct 6, 2017
| const index = tabValue.get('index') | ||
| const windowId = tabValue.get('windowId') | ||
| const pinnedTabsCount = tabState.getPinnedTabsByWindowId(state, windowId).size | ||
| tabState.getTabsByWindowId(state, windowId) |
There was a problem hiding this comment.
same as above- the method chaining should work fine... it's just a lot to read
cezaraugusto
approved these changes
Oct 6, 2017
bbondy
added a commit
that referenced
this pull request
Oct 6, 2017
18 Unbelievable ways to get rid of dead tabs on tab close
bbondy
added a commit
that referenced
this pull request
Oct 6, 2017
18 Unbelievable ways to get rid of dead tabs on tab close
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this pull request
Nov 9, 2017
18 Unbelievable ways to get rid of dead tabs on tab close
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests