Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix wide bravery panel to stop covering the webview #11880

Merged
merged 2 commits into from
Nov 20, 2017
Merged

Fix wide bravery panel to stop covering the webview #11880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb34aaf
Set braveryPanel list width to zero
Nov 9, 2017
38cbbe3
Avoid a very long domain name from covering the webview
Nov 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions app/renderer/components/main/braveryPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,12 @@ const displayHost = {
fontWeight: 'normal',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
overflow: 'hidden'
overflow: 'hidden',

// See #11878: avoid a very long domain drom covering the webview.
// The value should maintain the panel width until 0.19.
// https://github.com/brave/browser-laptop/blob/0.19.x/app/renderer/components/main/braveryPanel.js#L708
maxWidth: '320px'
}
const editGlobalMarginBottom = '.25rem'

Expand Down Expand Up @@ -928,7 +933,11 @@ const styles = StyleSheet.create({
braveryPanel__body__ul__li: {
listStyleType: 'none',
padding: '10px 0',
cursor: 'text'
cursor: 'text',

// #9839 and #11878: Avoid the panel width from increasing.
width: 0,
whiteSpace: 'nowrap'
},
braveryPanel__body__hr: {
background: globalStyles.braveryPanel.body.hr.background,
Expand Down Expand Up @@ -981,10 +990,6 @@ const styles = StyleSheet.create({
braveryPanel_compact__body__ul__li: {
padding: '5px 0',

// #9839: Avoid the panel width from increasing
width: 0,
whiteSpace: 'nowrap',

':first-of-type': {
paddingTop: 0
},
Expand Down