Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix search favicon path on windows #14704

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jul 10, 2018

for some reason, the windows path has an extra ../ prefix compared to
mac so the favicon doesn't load. this works around the issue by removing
a ../ on windows.

fix #14653

Test Plan:

  1. open new tab
  2. hit :g in the urlbar
  3. the search favicon should load on all platforms

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

for some reason, the windows path has an extra `../` prefix compared to
mac so the favicon doesn't load. this works around the issue by removing
a `../` on windows.

Test Plan:
1. open new tab
2. hit `:g` in the urlbar
3. the search favicon should load on all platforms
Copy link
Collaborator

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ tested manually on Windows. shows correct favicon

@bsclifton bsclifton merged commit 3d830d7 into master Jul 10, 2018
@bsclifton bsclifton deleted the fix/windows-favicon-path branch July 10, 2018 20:16
bsclifton added a commit that referenced this pull request Jul 10, 2018
bsclifton added a commit that referenced this pull request Jul 10, 2018
@bsclifton
Copy link
Member

master 3d830d7
0.24.x 01a1518
0.23.x 7f40503

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search icon in URLbar should be a local resource
3 participants