Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow upload script to check if current signature exists. #14705

Merged
merged 2 commits into from
Jul 10, 2018

Conversation

mbacchi
Copy link

@mbacchi mbacchi commented Jul 10, 2018

This was always signing the RPM because the test was failing,
now we will test and if the signature exists then move on.

The error seen was:
tools/upload_to_rpm_repo: line 18: !rpm: command not found

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

This was always signing the RPM because the test was failing,
now we will test and if the signature exists then move on.

The error seen was:
tools/upload_to_rpm_repo: line 18: !rpm: command not found
@mbacchi mbacchi requested review from bsclifton and evq July 10, 2018 19:09
evq
evq previously approved these changes Jul 10, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit e78fc93 into master Jul 10, 2018
@bsclifton bsclifton deleted the upload_to_rpm_repo branch July 10, 2018 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants