This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Cloned tabs appear next to the original one #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayumi
force-pushed
the
cloned-tabs-next-to-og
branch
from
0f47e16
to
f8b0758
Compare
| .ipcSend('shortcut-set-active-frame-by-index', 0) | ||
| .windowByUrl(Brave.browserWindowUrl) | ||
| .ipcSend(messages.SHORTCUT_ACTIVE_FRAME_CLONE) | ||
| .windowByUrl(Brave.browserWindowUrl) |
There was a problem hiding this comment.
this is one of the places where you really have to be careful. There is a race condition between cloning the frame and selecting the window. If the actual frame is created after the windowByUrl call, but before the waitForExist call, the waitForExist will fail because it's actually looking for the selector the new tab
There was a problem hiding this comment.
one option is to wait until getTabCount returns the incremented count
There was a problem hiding this comment.
thanks, that is helpful – I decided to check getTabCount
ayumi
force-pushed
the
cloned-tabs-next-to-og
branch
from
f8b0758
to
e4ff6eb
Compare
|
@bridiver ty for the feedback. Have updated tests – can you re-review? |
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test
Fix #2779