From 0794664d2b0cf62cc8feecd9a0571c382430838d Mon Sep 17 00:00:00 2001 From: Brian Clifton Date: Fri, 16 Sep 2016 00:04:45 -0700 Subject: [PATCH] - History now uses title (not custom title) - History page also uses cursor: default, to look more app-like Fixes https://github.com/brave/browser-laptop/issues/4029 Auditors: @bbondy @srirambv Test Plan: Part 1 1. Visit https://clifton.io/about/ 2. Bookmark the site; set the title to "TESTING 123" 3. Bring up the history page (Ctrl+Y / Cmd+Y) 4. Verify the entry shows up AND uses the title "About me" (not TESTING 123) Part 2 5. Move mouse over the table data. Notice it stays as the cursor. --- js/about/history.js | 6 +++--- less/about/history.less | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/js/about/history.js b/js/about/history.js index 64489649c9e..5dc0d47420c 100644 --- a/js/about/history.js +++ b/js/about/history.js @@ -43,8 +43,8 @@ class HistoryDay extends ImmutableComponent { : '', value: entry.get('lastAccessedTime') }, - entry.get('customTitle') || entry.get('title') - ? entry.get('customTitle') || entry.get('title') + entry.get('title') + ? entry.get('title') : entry.get('location'), urlutils.getHostname(entry.get('location'), true) ])} @@ -134,7 +134,7 @@ class AboutHistory extends React.Component { } searchedSiteDetails (searchTerm, siteDetails) { return siteDetails.filter((siteDetail) => { - const title = siteDetail.get('customTitle') + siteDetail.get('title') + siteDetail.get('location') + const title = siteDetail.get('title') + siteDetail.get('location') return title.match(new RegExp(searchTerm, 'gi')) }) } diff --git a/less/about/history.less b/less/about/history.less index 0dead586247..d78d61664d6 100644 --- a/less/about/history.less +++ b/less/about/history.less @@ -118,6 +118,10 @@ body { margin-right: 10px; } } + + .sortableTable { + cursor: default; + } } } }