Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Yandex.com as a search engine #5964

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Add Yandex.com as a search engine #5964

merged 1 commit into from
Dec 1, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #2703

Also includes

  • small refactor in js/components/urlBar.js which should make future changes easier (and opens this up to unit testing)
  • removes permafail webdriver test that should have been removed with Add default icon for url that has a broken file #5826 (I missed the fact CI failed on this when reviewing)

This does not include search suggestions; I broke that out and captured with #5963

Auditors: @bbondy, @cezaraugusto

Test Plan

  1. Launch Brave and open Preferences
  2. Set Yandex as your default search engine
  3. Search in the omnibox, confirm it shows results on yandex.com
  4. Check the URL that was created; client ID (clid=) should be:
  • 2274777 on Windows
  • 2274776 on macOS
  • 2274778 on linux
  1. Try the search engine shortcut, :ya and do a search in the omnibox

@cezaraugusto
Copy link
Contributor

LGTM

@bbondy
Copy link
Member

bbondy commented Dec 1, 2016

++ please rebase and then merge @bsclifton

Fixes #2703

Also includes
- small refactor in js/components/urlBar.js which should make future changes easier (and opens this up to unit testing)
- removes permafail webdriver test that should have been removed with #5826 (I missed the fact CI failed on this when reviewing)

Auditors: @bbondy, @cezaraugusto

Test Plan:
1. Launch Brave and open Preferences
2. Set Yandex as your default search engine
3. Search in the omnibox, confirm it shows results on yandex.com
4. Check the URL that was created; client ID (clid=) should be:
  - 2274777 on Windows
  - 2274776 on macOS
  - 2274778 on linux
5. Try the search engine shortcut, :ya and do a search in the omnibox
@bsclifton bsclifton merged commit 6db701a into brave:master Dec 1, 2016
@bsclifton bsclifton deleted the search-yandex branch December 1, 2016 16:55
@luixxiul luixxiul modified the milestones: 0.12.15, 0.13.0 Dec 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants