Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Yandex.com as a search engine #5964

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Add Yandex.com as a search engine #5964

merged 1 commit into from
Dec 1, 2016

Commits on Dec 1, 2016

  1. Add Yandex.com as a search engine

    Fixes #2703
    
    Also includes
    - small refactor in js/components/urlBar.js which should make future changes easier (and opens this up to unit testing)
    - removes permafail webdriver test that should have been removed with #5826 (I missed the fact CI failed on this when reviewing)
    
    Auditors: @bbondy, @cezaraugusto
    
    Test Plan:
    1. Launch Brave and open Preferences
    2. Set Yandex as your default search engine
    3. Search in the omnibox, confirm it shows results on yandex.com
    4. Check the URL that was created; client ID (clid=) should be:
      - 2274777 on Windows
      - 2274776 on macOS
      - 2274778 on linux
    5. Try the search engine shortcut, :ya and do a search in the omnibox
    bsclifton committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    8255147 View commit details
    Browse the repository at this point in the history