This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove merge into toolbar option from importer #8402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #7194 Auditors: @bsclifton, @bbondy Test Plan: a. getNextFolderName covered by unittest b. Import bookmark: 1. Import bookmarks from other browser or html 2. There will always a folder contains the imported bookmarks 3. If the folder name already exist, it will be "Imported from XXX (1)", "Imported from XXX (2)" ... etc
bsclifton
approved these changes
May 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
a. getNextFolderName covered by unittest
b. Import bookmark:
it will be "Imported from XXX (1)", "Imported from XXX (2)" ... etc
Description
fix #7194
Auditors: @bsclifton, @bbondy
git rebase -ito squash commits (if needed).