Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix border-radius of commonFormBottomWrapper #8654

Merged
merged 1 commit into from
May 3, 2017
Merged

Fix border-radius of commonFormBottomWrapper #8654

merged 1 commit into from
May 3, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 3, 2017 •
edited
Loading

Closes #8649

Auditors:

Test Plan:

  1. Open about:styles
  2. Click "commonForm"
  3. Make sure the dialog has border-radius on bottom right and left
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix border-radius of commonFormBottomWrapper
2e1162a 
Closes #8649

Auditors:

Test Plan:
1. Open about:styles
2. Click "commonForm"
3. Make sure the dialog has border-radius on bottom right and left
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label May 3, 2017
@luixxiul luixxiul added this to the 0.15.2 milestone May 3, 2017
@luixxiul luixxiul self-assigned this May 3, 2017
@luixxiul luixxiul mentioned this pull request May 3, 2017
Closed
srirambv
srirambv approved these changes May 3, 2017
View reviewed changes
Copy link
Collaborator

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

cezaraugusto
cezaraugusto approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit c559e77 into brave:master May 3, 2017
@luixxiul luixxiul deleted the fix-commonFormBottomWrapper-radius branch May 3, 2017 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@srirambv srirambv srirambv approved these changes

Assignees

@luixxiul luixxiul

Labels
polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging this pull request may close these issues.
3 participants
@luixxiul @cezaraugusto @srirambv