This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Polish notification button #9239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
commented
Jun 4, 2017
| @@ -88,7 +88,7 @@ const styles = StyleSheet.create({ | |||
| cursor: 'pointer', | |||
| lineHeight: 1.25, | |||
| width: 'auto', | |||
| height: 'auto', | |||
| height: '32px', | |||
There was a problem hiding this comment.
The reason why setting this value is to force the specified height. By setting it to auto the value can slightly (~2px) change as it is not intended.
Known issue: with this change the buttons on Brave payments gets broken. Setting their height to 37px would fix the issue.
There was a problem hiding this comment.
Otherwise: simply removing the font-size and padding specification on button.less makes the buttons size standard.
If the buttons become too small due to the change, then we would have to create another component like preferenceItem.
|
needs rebase pls |
from a viewpoint of accessibility Fixes #9237 Auditors: Test Plan: 1. Open about:preferences#general 2. Change lang setting 3. Click 'No' with a mouse using an arm opposite to a dominant arm 4. Check if you could click the button more easily than the current one
added 2 commits
June 6, 2017 16:53
Fixes #9238 Closes #9280 - Reorganize secondaryColor and primaryColor buttons - Add overflow-x to pre - Add secondaryColor to notificationItem Auditors: Test Plan: 1. Open about:styles#buttons 2. Make sure the notificationItem button is rendered as a white button 3. Make sure the code sample boxes are scrollable
I almost broke my arm doing this 😝 |
This was referenced Jun 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9237
Fixes #9238
Closes #9280
Test Plan 1
about:preferences#generalNowith a mouse using an arm opposite to a dominant armTest Plan 2
about:styles#buttonsSubmitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests