From c81548c8b2f8128aec1ddeae6a41626b3db47be1 Mon Sep 17 00:00:00 2001 From: bridiver <github@brianjohnson.cc> Date: Thu, 11 May 2017 12:01:12 -0700 Subject: [PATCH] also handle favIconUrl because that is what is in the chrome tabs api. Keeping faviconUrl for backward compatibility auditors @bbondy @darkdh --- atom/browser/api/atom_api_web_contents.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc index 50221bb403..5643772938 100644 --- a/atom/browser/api/atom_api_web_contents.cc +++ b/atom/browser/api/atom_api_web_contents.cc @@ -2506,7 +2506,8 @@ void WebContents::OnTabCreated(const mate::Dictionary& options, } std::string favicon_url; - if (options.Get("faviconUrl", &favicon_url)) { + if (options.Get("faviconUrl", &favicon_url) || + options.Get("favIconUrl", &favicon_url)) { content::FaviconStatus status; status.valid = true; status.url = GURL(favicon_url);