Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance verification test #13

Open
brenoguim opened this issue Oct 1, 2020 · 3 comments
Open

Add performance verification test #13

brenoguim opened this issue Oct 1, 2020 · 3 comments

Comments

@brenoguim
Copy link
Owner

The library contains a benchmark directory with a single benchmark. It would be nice to have a check that the performance using the library is actually better than the performance without it.

Not sure how to implement that. People with experience in Catch2 and cmake wanted :)

@eullerborges
Copy link
Contributor

I don't have experience with performance benchmarking in Catch2, but I've used it before with cmake. I'll look into what people normally do in those cases.

@eullerborges
Copy link
Contributor

It looks like that comparing the performance with only Catch2 isn't possible. It does seem though that Github Actions has support for Catch2 and performance tracking. What if we use that for performance regression testing?

I managed to build the tests with the performance test, but I couldn't quite understand if we're testing it here somehow. I see that without the -r junit to show the full textual output we get the times for each of the subsections. Are we somehow verifying that?

@brenoguim
Copy link
Owner Author

When you build the performance test it will run with the regular tests but no check is really being done.
I usually manually run the binary to see the output.

So it's all very brittle today. I like the idea from the link of keeping reference performance numbers and compare against that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants