🔨 Scrape Number and Specify Description

[migbro]

Partly addresses feature request # #33

• Is able to parse and return the correct Number attribute for info to update_header
• Allows user to specify in config a Description to override the default
  TO DO: Actually scrape the description from the source vcf file

Built locally, got compiler warning:

warning: unreachable pattern
   --> src/commands/encoder_cmd.rs:226:13
    |
226 |             _ => panic!(
    |             ^
    |
    = note: `#[warn(unreachable_patterns)]` on by default

When run, headers are output as desired

[brentp]

Thanks very much! Looks good.
Can you also add a test?

[brentp]

why did you change this?

[migbro]

Well, I am not ready for re-review yet. I made the change locally and I am using a remote machine to test. I hadn't made my test script yet, but just wanted to see the outputs in action before they are removed. I guess it's a little awkward to work on my own branch under scrutiny (I don't do cross-repo PRs often with external collaborators), but I'll re-request review when I think it's ready.

[migbro]

@brentp , so I have added the test, but in the process I was thinking, what if instead of prepending added by echtvar to all the INFO fields when one is provided or scraped (in the future), I instead do something similar like add an echtvar command line, like bcftools and VEP does. It's part of the second commit of https://github.com/brentp/echtvar/pull/34/files/580fb12830f55693dc0dd7d2165e00b9cfacaa91..3c4eca58fca3060d037059ed8083f958b9c26842 and when I tested it out, it came out like:
##echtvar_anno_Command=anno -i None generated-all.vcf anno.vcf.gz -e ["test.echtvar0"]
I can mess around with string a bit ( I am a complete rust novice ). Thoughts? Thanks in advance for your attentiveness!

[brentp]

@migbro , nicely done. I am OK with that echtvar command string. You can just join the archives with " -e " to get rid of the square brackets.

Let me know when you're ready for review.

[migbro]

@brentp ok, I think I have addressed PR comments and suggestions, since the last look I have:

• Cleaned up the added command line
• Convert A R G to 1, for Number, leave all other values alone
• Updated tests to account for changes

[brentp]

thank you!
I'll get this out in next release with changes from @dmiller15 in #35