Skip to content

Conversation

@Zagrebelin
Copy link

"Django<=4.0" is very strict rule, 4.0.1 and other minor versions are not satisfied this requirement.

@kylebebak
Copy link

kylebebak commented Mar 10, 2022

@brianjbuck

This would be a great help, if you've got a bit of time to merge this PR and release a new version of orjson renderer that would be excellent

Btw @Zagrebelin, the version range also needs to be updated (in fact only needs to be updated) in setup.py

@sidmitra
Copy link
Contributor

sidmitra commented Mar 23, 2022

@brianjbuck

My earlier PR got merged here. But i had a question there too

PS: Would it be ok to just specify the minimum version. i.e. >=3.2 ?

I reckon the related interface being used around DRF, Django is fairly stable, so we can get away with just pinning the minimum version i.e. >=3.2
In case there is a problem in the future, perhaps then we can decide to either fix or pin the higher/upper limit?

This way we might be able to avoid periodic tickets around each Django minor version upgrade.

I can send a PR if that works. Sent a PR removing the upper limit here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants