Allow precision 0 in Carbon DBAL types

briannesbitt · Jan 13, 2022 · 19a0881 · 19a0881
1 parent b989a73
commit 19a0881
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Carbon/Doctrine/CarbonTypeConverter.php b/src/Carbon/Doctrine/CarbonTypeConverter.php
@@ -36,7 +36,7 @@ protected function getCarbonClassName(): string
      */
     public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
     {
-        $precision = ($fieldDeclaration['precision'] ?: 10) === 10
+        $precision = ($fieldDeclaration['precision'] ?? 10) === 10
             ? DateTimeDefaultPrecision::get()
             : $fieldDeclaration['precision'];
         $type = parent::getSQLDeclaration($fieldDeclaration, $platform);

diff --git a/tests/Doctrine/CarbonTypesTest.php b/tests/Doctrine/CarbonTypesTest.php
@@ -64,10 +64,18 @@ public function testGetSQLDeclaration(string $name)
         $precision = DateTimeDefaultPrecision::get();
         $this->assertSame(6, $precision);
 
+        $this->assertSame('DATETIME', $type->getSQLDeclaration([
+            'precision' => 0,
+        ], new MySQL57Platform()));
+
         $this->assertSame('DATETIME(3)', $type->getSQLDeclaration([
             'precision' => 3,
         ], new MySQL57Platform()));
 
+        $this->assertSame('TIMESTAMP(0)', $type->getSQLDeclaration([
+            'precision' => 0,
+        ], new DB2Platform()));
+
         $this->assertSame('TIMESTAMP(6)', $type->getSQLDeclaration([
             'precision' => null,
         ], new DB2Platform()));