-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Translation tool] pl #2520
Comments
Hello, can you try |
I'm trying, but I'm getting an error. However the fix looks good to me. And it's much cleaner than the previous one.
|
Ah you have as version constraint via an other dependency, you can add this in your composer.json (or modify the nesbot/carbon line if there is one: "nesbot/carbon": "fix/pl-translations as 2.56.0", And run |
Something like that was necessary in composer.json:
I've done some testing and you can mark it as fixed. Thank you! |
Thanks. It will be released in 2.56.0. |
Additional fixes
I'm sorry, but my previous issue description (#2480) wasn't complete. Your changes in #2492 are insufficient.
For example you have corrected
za 1 godzina
toza 1 godzinę
for1 hour from now
. However if it's a part of a longer string, it's still incorrect.Example:
1 hour and 30 minutes from now
isza 1 godzina i 30 minut
, but it should beza 1 godzinę i 30 minut
.Some other examples:
a day and an hour from now
isza dzień i godzina
, but it should beza dzień i godzinę
,1 minute 2 seconds from now
isza 1 minuta 2 sekundy
, but it should beza 1 minutę 2 sekundy
.The text was updated successfully, but these errors were encountered: