Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translation tool] da #2584

Closed
kokoshneta opened this issue Apr 3, 2022 · 4 comments · Fixed by #2585
Closed

[Translation tool] da #2584

kokoshneta opened this issue Apr 3, 2022 · 4 comments · Fixed by #2585
Assignees
@kokoshneta
Labels
good first issue If you wish to contribute to Carbon you could start with this issue translation Rely to internationalization
Milestone
2.58.0

Comments

@kokoshneta
Copy link

kokoshneta commented Apr 3, 2022 •
edited
Loading

English da comments
Mon man man.
Mo ma ma.
Tue tir tir.
Tu ti ti.
Wed ons ons.
We on on.
Thu tor tor.
Th to to.
Fri fre fre.
Fr fr fr.
Sat lør lør.
Sa lø lø.
Sun søn søn.
Su sø sø.
Jan jan jan.
Feb feb feb.
Mar mar mar.
Apr apr apr.
Jun jun jun.
Jul jul jul.
Aug aug aug.
Sep sep sep.
Oct okt okt.
Nov nov nov.
Dec dec dec.
2 hours ago 2 timer siden for 2 timer siden

  1. According to the recommendations of the Danish Language Council, abbreviations of weekdays and months should have a closing stop (to match “min.”, “t.”, “s.”, etc., which already have the stop). They also appear as such in “Rigtigt kort: Anbefalede forkortelser” (“Properly brief: Recommended abbreviations”), published by the Council in 2004 and available at https://dsn.dk/wp-content/uploads/2021/01/Rigtigt-kort-indskannet.pdf.

  2. The preposition for in “for 2 timer siden” is required to express that something happened ‘2 hours ago’.
@kylekatarnls kylekatarnls self-assigned this Apr 3, 2022
@kylekatarnls kylekatarnls added the translation Rely to internationalization label Apr 3, 2022
@kylekatarnls kylekatarnls removed their assignment Apr 3, 2022
@kylekatarnls kylekatarnls added the good first issue If you wish to contribute to Carbon you could start with this issue label Apr 3, 2022
@kylekatarnls
Copy link
Collaborator

🙏 Thanks for the report. Sounds correct.

If you or anyone is willing to fix the translations, those are the files to be updated:
https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/da.php

And tests:
https://github.com/briannesbitt/Carbon/blob/master/tests/Localization/DaTest.php
https://github.com/briannesbitt/Carbon/blob/master/tests/Localization/DaDkTest.php
https://github.com/briannesbitt/Carbon/blob/master/tests/Localization/DaGlTest.php

@kokoshneta
Copy link
Author

PR #2585 added (I think correctly… let me know if I did something wrong.)

@kylekatarnls kylekatarnls added this to the 2.58.0 milestone Apr 3, 2022
@kylekatarnls kylekatarnls mentioned this issue Apr 3, 2022
Merged
@kylekatarnls
Copy link
Collaborator

Thank you so much 🙏 running the automated tests, if all green it's good to be merged.

@kylekatarnls
Copy link
Collaborator

This will be fixed in the next release, it can be tested using composer require "nesbot/carbon:dev-master as 2.58.0"

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kokoshneta kokoshneta

Labels
good first issue If you wish to contribute to Carbon you could start with this issue translation Rely to internationalization
Projects
None yet
Milestone
2.58.0
Development

Successfully merging a pull request may close this issue.

[Danish] Weekday and month abbreviations + ‘ago’
2 participants
@kylekatarnls @kokoshneta