Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use stricter string assertions #2360

Merged
merged 1 commit into from
Jun 27, 2021
Merged

Always use stricter string assertions #2360

merged 1 commit into from
Jun 27, 2021

Conversation

lucasmichot
Copy link
Collaborator

Always use stricter string assertions when possible.

kylekatarnls
kylekatarnls approved these changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@kylekatarnls kylekatarnls merged commit 91c84f4 into briannesbitt:master Jun 27, 2021
@kylekatarnls kylekatarnls added this to the 2.50.0 milestone Jun 28, 2021
@lucasmichot lucasmichot deleted the stricter-assertions branch May 13, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmichot @kylekatarnls