Lang/En: Ordinal function: int === float, Fixes #2549

[levu42]

Compare float to float, not float to int

Fix #2549

[kylekatarnls]

Thanks for the report and the work on it🙏

As per tests we now have: '11st' which is not correct, we should have '11th'.

For a proper fix for this it would need:

• a unit test to show the case we fix (so we can ensure it does not regress and we see how the "Implicit conversion" error can be triggered and be sure the fix actually avoid this error to occur)
• fix all languages using the same principle ~~ or % a / b, I think it's only used for selecting numbers from 10 to 19 (maybe this can be done is a more explicit way)
• keep compatibility from PHP 7.1.8

Would you be possible for you to update this pull-requests with those items?

[levu42]

@kylekatarnls Thanks for your feedback! I'll work on fixing all the mentioned points in the next days!

[kylekatarnls]

Deprecations are now converted into exception in the unit tests so they will be detected by the build. Then those int cast are now fixed, you can try composer require "nesbot/carbon:dev-master as 2.58.0" if you want to test the next version.