Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.1 deprecations #2551

Merged
merged 5 commits into from
Feb 23, 2022
Merged

Fix PHP 8.1 deprecations #2551

merged 5 commits into from
Feb 23, 2022

Conversation

kylekatarnls
Copy link
Collaborator

@kylekatarnls kylekatarnls commented Feb 17, 2022

Fix #2549
Closes #2550

@kylekatarnls kylekatarnls force-pushed the fix/conversion-loss branch 2 times, most recently from 7a6fdcc to 105eb9a Compare February 23, 2022 17:48
@kylekatarnls kylekatarnls marked this pull request as ready for review February 23, 2022 20:25
@kylekatarnls kylekatarnls changed the title Add unit tests for case #2549 Fix PHP 8.1 deprecations Feb 23, 2022
@kylekatarnls kylekatarnls added this to the 2.58.0 milestone Feb 23, 2022
@kylekatarnls kylekatarnls merged commit 2b515d7 into master Feb 23, 2022
@kylekatarnls kylekatarnls deleted the fix/conversion-loss branch February 23, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1 Implicit conversion from float to int loses precision
1 participant