refactor(Project Paths): Use std::default for Args

From the days when `new`, `load`, and `snapshot` were in separate repositories and before `common` existed code for getting the default directory and project path, as well as checking first run was duplicated in each crate.

Finally refactor the duplication out. Additionally stop using string formed arguments and utilize real structs. Uses `std::default` to make struct creation simpler and less noisy in tests.

common/Cargo.toml

@@ -9,4 +9,5 @@ doctest = false
 
 [dependencies]
 dirs            = "1.0.5"
+rand            = "0.3.15"
 rustc-serialize = "0.3"

common/src/args.rs

@@ -1,4 +1,5 @@
 //! The struct managing cli args
+use rand::random;
 
 /// The args struct for taking arguments passed in from the command line
 /// and making it easier to pass around.
@@ -26,3 +27,22 @@ pub struct Args {
     pub cmd_new: bool,
     pub cmd_snapshot: bool,
 }
+
+impl Default for Args {
+    fn default() -> Self {
+        let name = format!("{}", random::<u16>());
+
+        Args {
+            arg_project: name,
+            cmd_edit: false,
+            cmd_new: true,
+            cmd_snapshot: false,
+            flag_d: true,
+            flag_debug: false,
+            flag_f: false,
+            flag_p: None,
+            flag_t: None,
+            flag_v: false,
+        }
+    }
+}

common/src/lib.rs

@@ -1,4 +1,5 @@
 extern crate dirs;
+extern crate rand;
 
 pub mod args;
 pub mod first_run;

common/src/project_paths.rs

@@ -69,81 +69,39 @@ mod test {
 
     #[test]
     fn expects_tmp_as_default_homedir() {
-        let args = Args {
-            arg_project: "projectname".to_string(),
-            cmd_edit: false,
-            cmd_new: false,
-            cmd_snapshot: false,
-            flag_d: false,
-            flag_debug: false,
-            flag_dryrun: false,
-            flag_f: false,
-            flag_p: None,
-            flag_t: None,
-            flag_v: false,
-        };
-
+        let args: Args = Default::default();
         let project_paths = project_paths(&args);
+
         assert_eq!(project_paths.home_directory, PathBuf::from("/tmp"))
     }
 
     #[test]
     fn expects_muxed_as_default_project_dir() {
-        let args = Args {
-            arg_project: "projectname".to_string(),
-            cmd_edit: false,
-            cmd_new: false,
-            cmd_snapshot: false,
-            flag_d: false,
-            flag_debug: false,
-            flag_dryrun: false,
-            flag_f: false,
-            flag_p: None,
-            flag_t: None,
-            flag_v: false,
-        };
-
+        let args: Args = Default::default();
         let project_paths = project_paths(&args);
+
         assert_eq!(project_paths.project_directory, PathBuf::from("/tmp/.muxed"))
     }
 
     #[test]
     fn expects_spacey_as_homedir() {
         let args = Args {
-            arg_project: "projectname".to_string(),
-            cmd_edit: false,
-            cmd_new: false,
-            cmd_snapshot: false,
-            flag_d: false,
-            flag_debug: false,
-            flag_dryrun: false,
-            flag_f: false,
             flag_p: Some("/spacey".to_string()),
-            flag_t: None,
-            flag_v: false,
+            ..Default::default()
         };
-
         let project_paths = project_paths(&args);
+
         assert_eq!(project_paths.project_directory, PathBuf::from("/spacey"))
     }
 
     #[test]
     fn expects_projectname_as_yml_file() {
         let args = Args {
             arg_project: "projectname".to_string(),
-            cmd_edit: false,
-            cmd_new: false,
-            cmd_snapshot: false,
-            flag_d: false,
-            flag_debug: false,
-            flag_dryrun: false,
-            flag_f: false,
-            flag_p: None,
-            flag_t: None,
-            flag_v: false,
+            ..Default::default()
         };
-
         let project_paths = project_paths(&args);
+
         assert_eq!(project_paths.project_file, PathBuf::from("/tmp/.muxed/projectname.yml"))
     }
 }

load/tests/helpers/mod.rs

@@ -65,16 +65,9 @@ pub fn test_with_contents(contents: &[u8]) -> snapshot::tmux::session::Session {
 
 fn open_muxed(project: &str, project_root: &Path) -> Result<(), String> {
     let args = Args {
-        flag_debug: false,
-        flag_d: true,
-        flag_v: false,
-        flag_f: false,
-        flag_p: Some(format!("{}", project_root.display())),
-        flag_t: None,
         arg_project: project.to_string(),
-        cmd_edit: false,
-        cmd_new: false,
-        cmd_snapshot: false,
+        flag_p: Some(format!("{}", project_root.display())),
+        ..Default::default()
     };
 
     load::exec(args)

new/tests/new.rs

@@ -15,16 +15,10 @@ mod test {
 
         pub fn new(project: &str, project_root: &PathBuf) -> Result<(), String> {
             let args = Args {
-                flag_debug: false,
-                flag_d: true,
-                flag_v: false,
-                flag_f: false,
                 flag_p: Some(format!("{}", project_root.display())),
-                flag_t: None,
                 arg_project: project.to_string(),
-                cmd_edit: false,
                 cmd_new: true,
-                cmd_snapshot: false,
+                ..Default::default()
             };
 
             new::exec(args)